Yeah, Skarmory is best for indirect damage rather than attack. It's Defence is it's main strong point, being one of the highest in the game, combined with the Steel type for extra defence. For in game purposes, it's not the best thing in the world, but if you're fighting against a human player, try this:
Spikes
Roar
Toxic
Drill Peck
This is the standard move set for Skarmory. Drop 3 layers of Spikes (the most you can have), then use Toxic and Roar alternatively. If you find someone who can use a Super-effective attack (Fire and Electric), then switch to someone who can avoid/resist it, and throw Skarm back in when he's gone. A good choice for partner is any Ground type (for electric moves), a water type for fire moves, or anyone with a high Special Defence (Blissey is the most common partner for Skarm, although you'll have to wait for FR and LG before you can get one in game).
EDIT: Magneton is probably the best anti-Skarmory, so be warned. I still have trouble in game, even with a 40 level advantage. Immune to Toxic, can't be Roared out due to Magnet Pull, and having Electric attacks to take down Skarmory in one hit (two if he's lucky). And of course, has a 4 x resistance to both Steel and Flying attacks.