[Scripting Question] Heal Pokemon over time (Overworld)

[e463gx]

Hoping someone can help me here. I'm looking to replace Pokecenters with healing over time. Preferably it would be tied to steps taken if not time itself, and ideally would be restricted to Pokemon in a PC Box.

I see the game primarily uses "Recover All" when healing at Pokecenters and not a script call.

Any advice?

 

[Frost the Fox]

Look at how Essentials handles Poison damage in the overworld

 

[e463gx]

Great idea!

I found the relevant code that calculates Poison as well as Happiness on step.

Happiness:

Spoiler:

# Party Pokémon gain happiness from walking
EventHandlers.add(:on_player_step_taken, :gain_happiness,
proc {
$PokemonGlobal.happinessSteps = 0 if !$PokemonGlobal.happinessSteps
$PokemonGlobal.happinessSteps += 1
next if $PokemonGlobal.happinessSteps < 128
$player.able_party.each do |pkmn|
pkmn.changeHappiness("walking") if rand(2) == 0
end
$PokemonGlobal.happinessSteps = 0
}
)

Poison:

Spoiler:

# Poison party Pokémon
EventHandlers.add(:on_player_step_taken_can_transfer, :poison_party,
proc { |handled|
# handled is an array: [nil]. If [true], a transfer has happened because of
# this event, so don't do anything that might cause another one
next if handled[0]
next if !Settings::POISON_IN_FIELD || $PokemonGlobal.stepcount % 4 != 0
flashed = false
$player.able_party.each do |pkmn|
next if pkmn.status != :POISON || pkmn.hasAbility?(:IMMUNITY)
if !flashed
pbFlash(Color.new(255, 0, 0, 128), 8)
flashed = true
end
pkmn.hp -= 1 if pkmn.hp > 1 || Settings::POISON_FAINT_IN_FIELD
if pkmn.hp == 1 && !Settings::POISON_FAINT_IN_FIELD
pkmn.status = :NONE
pbMessage(_INTL("{1} survived the poisoning.\\nThe poison faded away!\1", pkmn.name))
next
elsif pkmn.hp == 0
pkmn.changeHappiness("faint")
pkmn.status = :NONE
pbMessage(_INTL("{1} fainted...", pkmn.name))
end
if $player.able_pokemon_count == 0
handled[0] = true
pbCheckAllFainted
end
end
}
)

I think it should be easy to just add a third option in this area for healing, but could still use some guidance on how to correctly incorporate the below underlined areas.

# Heal Party Pokémon
EventHandlers.add(:on_player_step_taken_can_transfer, :heal_party,
proc { |handled|
# handled is an array: [nil]. If [true], a transfer has happened because of
# this event, so don't do anything that might cause another one
next if handled[0]
pkmn.hp += 1 if pkmn.hp < pkmn.totalhp
end
}

1.) What does the :poison_party and :gain_happiness commands do, and do I need to create :heal_party somewhere?
2.) Am I using totalhp correctly here?

 

[James Davy]

Your code appears to be correct. I would suggest a larger HP gain rate for higher-level Pokémon unless you want to take hundreds of steps to fully heal a Pokémon. Perhaps an HP gain by a ceiling quotient of totalhp by the maximum number of steps as shown here:

hpgain = (pkmn.totalhp / maxSteps).ceil