[Scripting Question] Coding Toucannon's Beak Blast

[Uzagi]

So I tried to code it's Beak Blast ; but I'm not sure if it'll work... can you guys check this out?
I have little knowledge of RGSS since I'm trying to learn since few days

def pbTwoTurnAttack(attacker)
@immediate=false;

def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
if @immediate || attacker.effects[PBEffects::TwoTurnAttack]>0
pbShowAnimation(@id,attacker,opponent,1,alltargets,showanimation) # Charging anim
@battle.pbDisplay(_INTL("{1} começou a esquentar!",attacker.pbThis))
end
def pbAdditionalEffect(attacker,opponent)
return if opponent.damagestate.substitute
if opponent.pbCanBurn?(attacker,false,self)
opponent.pbBurn(attacker)
end
return 0 if attacker.effects[PBEffects::TwoTurnAttack]>0
return super(attacker,opponent,hitnum,alltargets,showanimation)
end
end

 

[mgriffin]

You don't want to put a def inside another def. So at the very least it should look more like this:

def pbTwoTurnAttack(attacker)
  @immediate=false;
end

def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
  if @immediate || attacker.effects[PBEffects::TwoTurnAttack]>0
    pbShowAnimation(@id,attacker,opponent,1,alltargets,showanimation) # Charging anim
    @battle.pbDisplay(_INTL("{1} começou a esquentar!",attacker.pbThis))
  end
  return 0 if attacker.effects[PBEffects::TwoTurnAttack]>0
  return super(attacker,opponent,hitnum,alltargets,showanimation)
end

def pbAdditionalEffect(attacker,opponent)
  return if opponent.damagestate.substitute
  if opponent.pbCanBurn?(attacker,false,self)
    opponent.pbBurn(attacker)
  end
end

(I also moved the super call and the line above it because they clearly belonged to pbEffect, not pbAdditionalEffect).

All I did was rearrange things though, I've made no attempt to check that things make sense.

 

[WolfPP]

Spoiler:

Also, you need to add POWERHERB too. Like:

Spoiler:

  def pbTwoTurnAttack(attacker)
    @immediate=false
    if !@immediate && attacker.hasWorkingItem(:POWERHERB)
      @immediate=true
    end
    return false if @immediate
    return attacker.effects[PBEffects::TwoTurnAttack]==0
  end

  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if @immediate || attacker.effects[PBEffects::TwoTurnAttack]>0
      pbShowAnimation(@id,attacker,opponent,1,alltargets,showanimation) # Charging anim
      @battle.pbDisplay(_INTL("{1} is heating up its beak!",attacker.pbThis))
      #attacker.effects[PBEffects::BeakBlast]=1
    end
    if @immediate
      @battle.pbCommonAnimation("UseItem",attacker,nil)
      @battle.pbDisplay(_INTL("{1} became fully charged due to its Power Herb!",attacker.pbThis))
      attacker.pbConsumeItem
      attacker.effects[PBEffects::BeakBlast]=0
    end
    return 0 if attacker.effects[PBEffects::TwoTurnAttack]>0
    return super(attacker,opponent,hitnum,alltargets,showanimation)
  end

  def pbAdditionalEffect(attacker,opponent)
    return if opponent.damagestate.substitute
    if opponent.pbCanBurn?(attacker,false,self)
      opponent.pbBurn(attacker)
    end
  end
end

Also, im testing it and Toucannon needs 3 turns to take damage with that move (because we add it with -3 Priority, like Bulbapedia said: https://bulbapedia.bulbagarden.net/wiki/Beak_Blast_(move)). However, Toucannon inflict damage into the next turn:
https://www.youtube.com/watch?v=fcBHkRqK3Hc

How can we fix it?

EDIT: The charge's move always active first (like original), in 'PokeBattle_Battle' (CF20 its your code for its move):

    # Use attacks
    for i in priority
      next if i.effects[PBEffects::SkipTurn]
      if pbChoseMoveFunctionCode?(i.index,0x115) # Focus Punch
        pbCommonAnimation("FocusPunch",i,nil)
        pbDisplay(_INTL("{1} is tightening its focus!",i.pbThis))
[COLOR="Red"]      elsif pbChoseMoveFunctionCode?(i.index,0xCF20) # Beak Blast
        pbCommonAnimation("Burn",i,nil)
        pbDisplay(_INTL("{1} started heating up its beak!",i.pbThis))
      end[/COLOR]
    end

To burn the opponent if inflicts a contact move. in 'PokeBattle_Battler':

        if target.hasWorkingItem(:ROCKYHELMET,true) && !user.fainted?
          if !user.hasWorkingAbility(:MAGICGUARD)
            PBDebug.log("[Item triggered] #{target.pbThis}'s Rocky Helmet")
            @battle.scene.pbDamageAnimation(user,0)
            user.pbReduceHP((user.totalhp/6).floor)
            @battle.pbDisplay(_INTL("{1} was hurt by the {2}!",user.pbThis,
               PBItems.getName(target.item)))
          end
        end
[COLOR="red"]        [email protected][target.index][2]
        if movex.function==0xCF20 && move.isContactMove? && 
         user.pbCanBurn?(false,movex,target)
          user.pbBurn(target)
        end[/COLOR]

Now, we need edit how its move will work in MoveEffects. Also, its like Focus Punch works (copy to Shell Trap. Only them haves -3 priority. So, its the same to all of them). Im tryin to find how Focus Punch works but idk how to add pbBurn effect to Beak Blast.

We are wrong because Beak Blast is not a TwoTurns. Also, i think i done:
Into your move.txt:

623,BEAKBLAST,Beak Blast,[COLOR="red"]CF20[/COLOR],100,FLYING,Physical,100,15,0,00,-3,[COLOR="red"]bn[/COLOR],"The user first heat up its beak, and then it attacks the target."

In 'PokeBattle_MoveEffects' add:

################################################################################
# If anyone makes contact with the Pokemon while they are  charging this move, 
# they will be inflicted with a burn (Beak Blast)
################################################################################
class PokeBattle_Move_CF20 < PokeBattle_Move
end

Then, in 'PokeBattle_Battler' add the red lines:

Spoiler:

[COLOR="Red"]        [email protected][target.index][2]
        if movex.function==0xCF20 && # Beak Blast
             move.isContactMove? && user.pbCanBurn?(false,movex,target)
          user.pbBurn(target)
        end
[/COLOR]        if target.hasWorkingAbility(:STATIC,true) && @battle.pbRandom(10)<3 &&
         user.pbCanParalyze?(nil,false)
          @battle.pbDisplayEffect(target)
          PBDebug.log("[Ability triggered] #{target.pbThis}'s Static")
          #user.pbParalyze(target,_INTL("{1}'s {2} paralyzed {3}! It may be unable to move!",
             #target.pbThis,PBAbilities.getName(target.ability),user.pbThis(true)))
          user.pbParalyze(target)
          if EFFECTMESSAGES
            @battle.pbDisplay(_INTL("{1} was paralyzed!",user.pbThis(true)))
          else
            @battle.pbDisplay(_INTL("{1}'s {2} paralyzed {3}!  It may be unable to move!",
               target.pbThis,PBAbilities.getName(target.ability),user.pbThis(true)))
          end
        end

Finally, search for 'if pbChoseMoveFunctionCode?(i.index,0x115) # Focus Punch' inside 'PokeBattle_Battle' and add:

Spoiler:

    # Use attacks
    for i in priority
      next if i.effects[PBEffects::SkipTurn]
      if pbChoseMoveFunctionCode?(i.index,0x115) # Focus Punch
        pbCommonAnimation("FocusPunch",i,nil)
        pbDisplay(_INTL("{1} is tightening its focus!",i.pbThis))
      elsif pbChoseMoveFunctionCode?(i.index,0xCF20) # Beak Blast
        pbCommonAnimation("Burn",i,nil)
        pbDisplay(_INTL("{1} started heating up its beak!",i.pbThis))
      end
    end

The move will charge in first (before U-Turn i.e) and if opponent inflict damage with a contact move, will burn it, and the Beak Blast will be use and inflict damage AND finally the opponent will take damage with burn. If pokemon are sleeping, will charge the attack in first time and burn the opponent (if inflicted a contact move).
Credits goes to Rot8er_ConeX (https://www.pokecommunity.com/showthread.php?t=383035&page=2)
Video than i watched: https://www.youtube.com/watch?v=fcBHkRqK3Hc

 

[WolfPP]

Better code here: https://www.pokecommunity.com/threads/383035/page-5