[Scripting Question] Ability Like The Move Freeze-Dry

[mrbrandino]

I want to make a unique ability that makes any of the user's 4 moves super-effective against Grass-Type Pokemon despite the original Types of the user's moves.

This is similar to how the move Freeze-Dry works, but I have no idea how to implement that into an Ability and where to edit all the code to make it happen.



I have little to no coding knowledge, so if anyone can help me out and show me how and where to place code for this, I'd greatly appreciate it!

(I only want the user with the ability to be applied the effect. Other ally's on the field should not be super-effective against Grass, only the user of the ability.)

 

[WolfPP]

Well did you try just copy Freeze-Dry's code and edit for your ability?

    if @function==0x135 && !attacker.effects[PBEffects::Electrify] # Freeze-Dry
      mod1=4 if isConst?(otype1,PBTypes,:WATER)
      if isConst?(otype2,PBTypes,:WATER)
        mod2=(otype1==otype2) ? 2 : 4
      end
      if isConst?(otype3,PBTypes,:WATER)
        mod3=(otype1==otype3 || otype2==otype3) ? 2 : 4
      end
    end
    if attacker.hasWorkingAbility(:MAMMAMIA) && opponent.pbHasType?(:GRASS)
      mod1=4; mod2=4; mod3=4
    end

Maybe 2 instead 4. Anyway, test and give us the feedback.

 

[mrbrandino]

Well did you try just copy Freeze-Dry's code and edit for your ability?

    if @function==0x135 && !attacker.effects[PBEffects::Electrify] # Freeze-Dry
      mod1=4 if isConst?(otype1,PBTypes,:WATER)
      if isConst?(otype2,PBTypes,:WATER)
        mod2=(otype1==otype2) ? 2 : 4
      end
      if isConst?(otype3,PBTypes,:WATER)
        mod3=(otype1==otype3 || otype2==otype3) ? 2 : 4
      end
    end
    if attacker.hasWorkingAbility(:MAMMAMIA) && opponent.pbHasType?(:GRASS)
      mod1=4; mod2=4; mod3=4
    end

Maybe 2 instead 4. Anyway, test and give us the feedback.

So I placed the code under def pbEffectsOnDealingDamage(move,user,target,damage) in PokeBattle_Battler and I placed it exactly like the example you gave besides changing attacker to user and opponent to target
Unfortunately, it yielded no results at all. I tested it in a battle, but nothing happened differently at all.

Any more suggestions?

EDIT: I also tried implementing the code separately under #Ability effects and it gave me Name errors for the parts like "attacker" and "otype." I don't believe copying and pasting the code will suffice.

UPDATE: I plugged in the code under Freeze Dry's code on PokeBattle_Move and the code worked for the most part. It did make any move super effective against Grass types, however after the hit a message displays saying the damage the opponent received was reduced. I have no idea why it's doing this.

 

[JacktheLightningRipper]

I would also like to know because I'd like to make an ability that makes Grass, Electric, and Dragon types weak to Electric. So far I have this.

Battle::AbilityEffects::DamageCalcFromUser.add(:ABILITY,
  proc { |ability, user, target, move, mults, power, type|
    return Effectiveness::SUPER_EFFECTIVE_MULTIPLIER if defType == :GRASS
    return Effectiveness::SUPER_EFFECTIVE_MULTIPLIER if defType == :ELECTRIC
    return Effectiveness::SUPER_EFFECTIVE_MULTIPLIER if defType == :DRAGON
    return super
  }
)

This did not work. What would you recommend?

 

[Swdfm]

Hi, I'm not as awesome as Wolf, but I'm here, so I'll have to do!
Let's start with the guy from February 2020. Talk about the eye before the storm! Sorry you had to wait so long!
Ability that hits SE vs Grass types

Spoiler:

So, Freeze Dry does not quite do what the description of your ability wants to do, but it is a good start
You want your ability to make any move from the user to be super effective vs Grass types? Because Grass types don't suffer enough, apparently!
Though far from what we need, Mind's Eye might be a good place to start

1) Mind's Eye code in Battle::Move: (Thank you Gen 9 pack!)

alias paldea_pbCalcTypeModSingle pbCalcTypeModSingle
  def pbCalcTypeModSingle(moveType, defType, user, target)
    ret = paldea_pbCalcTypeModSingle(moveType, defType, user, target)
    if Effectiveness.ineffective_type?(moveType, defType)
      if user.hasActiveAbility?(:MINDSEYE) && defType == :GHOST
        ret = Effectiveness::NORMAL_EFFECTIVE_MULTIPLIER
      end
    end
    return ret
  end

2) I think a few tweaks and we more or less have it!

a) We change paldea_ to swdfm_ because Shameless Plug! (Would also clash with Gen 9 Pack!)
b) You said it doesn't matter what the original effectiveness was, so we remove the line starting with "if Effectiveness"
c) We remove its corresponding "end"
d) We change MINDSEYE to MAMMAMIA
e) We change GHOST to GRASS
f) We change NORMAL_EFFECTIVE_MULTIPLIER to SUPER_EFFECTIVE_MULTIPLIER (After checking it would work)

And here it is!

Mamma Mia (v21)

Spoiler:

class Battle::Move
  alias swdfm_pbCalcTypeModSingle pbCalcTypeModSingle
  def pbCalcTypeModSingle(moveType, defType, user, target)
    ret = swdfm_pbCalcTypeModSingle(moveType, defType, user, target)
    if user.hasActiveAbility?(:MAMMAMIA) && defType == :GRASS
      ret = Effectiveness::SUPER_EFFECTIVE_MULTIPLIER
    end
    return ret
  end
end

Ability that makes X moves SE vs A, B, C...

Spoiler:

1) Ok, Jack and the Lightning Seeds, over to you!
Your first issue is that you added return and super into an ability proc. That would not have worked in a month of Sundays unfortunately

Back in present day, and we want an ability that makes the user's electric type moves hit SE vs Grass, Electric, and Dragon types
Or do you literally mean "Grass, Electric, and Dragon types weak to Electric" meaning all of them on the field when a Pokemon with that ability is on the field? If this is what you mean, let me know!

2) This ability sounds awfully similar to an ability I wrote 5 minutes ago!
Take a look at Mamma Mia from the first spoiler. Now we make some tweaks

a) It has to be an electric type move, so we will add that requirement in the "if"
b) I don't know what you want your ability to be called, so let's call it Here We Go Again!
c) It is Grass, Electric and Dragon, so let's have it work if any of those types are the deftype
.include is your bestie!
d) The rest can stay the same. We are going to indent it correctly though, because we have some decorum!

My My!

Here We Go Again

Spoiler:

class Battle::Move
  alias swdfm_pbCalcTypeModSingle pbCalcTypeModSingle
  def pbCalcTypeModSingle(moveType, defType, user, target)
    ret = swdfm_pbCalcTypeModSingle(moveType, defType, user, target)
    if moveType == :ELECTRIC &&
       user.hasActiveAbility?(:HEREWEGOAGAIN) &&
       [:GRASS, :ELECTRIC, :DRAGON].include?(defType)
      ret = Effectiveness::SUPER_EFFECTIVE_MULTIPLIER
    end
    return ret
  end
end

NOTE: I have tested neither of them! Please test yourself!
Hope these help!
Swdfm

[/spoiler]

 

[WillBill206]

Hi, I'm not as awesome as Wolf, but I'm here, so I'll have to do!
Let's start with the guy from February 2020. Talk about the eye before the storm! Sorry you had to wait so long!
Ability that hits SE vs Grass types

Spoiler:

So, Freeze Dry does not quite do what the description of your ability wants to do, but it is a good start
You want your ability to make any move from the user to be super effective vs Grass types? Because Grass types don't suffer enough, apparently!
Though far from what we need, Mind's Eye might be a good place to start

1) Mind's Eye code in Battle::Move: (Thank you Gen 9 pack!)

alias paldea_pbCalcTypeModSingle pbCalcTypeModSingle
  def pbCalcTypeModSingle(moveType, defType, user, target)
    ret = paldea_pbCalcTypeModSingle(moveType, defType, user, target)
    if Effectiveness.ineffective_type?(moveType, defType)
      if user.hasActiveAbility?(:MINDSEYE) && defType == :GHOST
        ret = Effectiveness::NORMAL_EFFECTIVE_MULTIPLIER
      end
    end
    return ret
  end

2) I think a few tweaks and we more or less have it!

a) We change paldea_ to swdfm_ because Shameless Plug! (Would also clash with Gen 9 Pack!)
b) You said it doesn't matter what the original effectiveness was, so we remove the line starting with "if Effectiveness"
c) We remove its corresponding "end"
d) We change MINDSEYE to MAMMAMIA
e) We change GHOST to GRASS
f) We change NORMAL_EFFECTIVE_MULTIPLIER to SUPER_EFFECTIVE_MULTIPLIER (After checking it would work)

And here it is!

Mamma Mia (v21)

Spoiler:

class Battle::Move
  alias swdfm_pbCalcTypeModSingle pbCalcTypeModSingle
  def pbCalcTypeModSingle(moveType, defType, user, target)
    ret = swdfm_pbCalcTypeModSingle(moveType, defType, user, target)
    if user.hasActiveAbility?(:MAMMAMIA) && defType == :GRASS
      ret = Effectiveness::SUPER_EFFECTIVE_MULTIPLIER
    end
    return ret
  end
end

Ability that makes X moves SE vs A, B, C...

Spoiler:

1) Ok, Jack and the Lightning Seeds, over to you!
Your first issue is that you added return and super into an ability proc. That would not have worked in a month of Sundays unfortunately

Back in present day, and we want an ability that makes the user's electric type moves hit SE vs Grass, Electric, and Dragon types
Or do you literally mean "Grass, Electric, and Dragon types weak to Electric" meaning all of them on the field when a Pokemon with that ability is on the field? If this is what you mean, let me know!

2) This ability sounds awfully similar to an ability I wrote 5 minutes ago!
Take a look at Mamma Mia from the first spoiler. Now we make some tweaks

a) It has to be an electric type move, so we will add that requirement in the "if"
b) I don't know what you want your ability to be called, so let's call it Here We Go Again!
c) It is Grass, Electric and Dragon, so let's have it work if any of those types are the deftype
.include is your bestie!
d) The rest can stay the same. We are going to indent it correctly though, because we have some decorum!

My My!

Here We Go Again

Spoiler:

class Battle::Move
  alias swdfm_pbCalcTypeModSingle pbCalcTypeModSingle
  def pbCalcTypeModSingle(moveType, defType, user, target)
    ret = swdfm_pbCalcTypeModSingle(moveType, defType, user, target)
    if moveType == :ELECTRIC &&
       user.hasActiveAbility?(:HEREWEGOAGAIN) &&
       [:GRASS, :ELECTRIC, :DRAGON].include?(defType)
      ret = Effectiveness::SUPER_EFFECTIVE_MULTIPLIER
    end
    return ret
  end
end

NOTE: I have tested neither of them! Please test yourself!
Hope these help!
Swdfm

[/spoiler]

This worked for me! I used the code for an ability called evaporation that makes fire type moves super effective against water types, and have been struggling to figure out how to do it for a while so thank you!